Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow bike walking through bicycle no thru traffic areas #6179

Conversation

richardkoszegi
Copy link
Contributor

Summary

Allows bike walking through bicycle no thru traffic areas.

Issue

Fixes #6178

Unit tests

Added 3 tests to verify bicycle traverse through bicycle no through edges (the restricted edge is in the start - middle - end).

@richardkoszegi richardkoszegi requested a review from a team as a code owner October 18, 2024 14:04
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev-2.x@f9ea044). Learn more about missing BASE report.
Report is 57 commits behind head on dev-2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6179   +/-   ##
==========================================
  Coverage           ?   69.93%           
  Complexity         ?    17734           
==========================================
  Files              ?     1996           
  Lines              ?    75411           
  Branches           ?     7722           
==========================================
  Hits               ?    52741           
  Misses             ?    19993           
  Partials           ?     2677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vesameskanen vesameskanen self-requested a review October 21, 2024 06:00
Copy link
Contributor

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Some notes, though:

  • I wonder if we should change bicycle nothru island pruning logic now.
  • Would it make sense to filter the first item away from the assertPath func of bikewalk tests?

@optionsome optionsome requested a review from vpaturet October 22, 2024 09:25
@t2gran t2gran added this to the 2.7 (next release) milestone Oct 22, 2024
@optionsome optionsome added the Improvement A functional improvement label Oct 24, 2024
@optionsome optionsome merged commit 2cc4ac5 into opentripplanner:dev-2.x Oct 24, 2024
5 checks passed
t2gran pushed a commit that referenced this pull request Oct 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Improvement A functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow bike walking through bicycle no thru traffic areas
6 participants