Fix NullPointerException when searching backwards with a frequency-based trip #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am going to submit this minimal fix for now and defer any refactoring until we have discussed #6213 . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6211 +/- ##
=============================================
+ Coverage 69.94% 70.03% +0.09%
- Complexity 17744 17785 +41
=============================================
Files 1998 2000 +2
Lines 75454 75515 +61
Branches 7723 7728 +5
=============================================
+ Hits 52778 52890 +112
+ Misses 20007 19950 -57
- Partials 2669 2675 +6 ☔ View full report in Codecov by Sentry. |
t2gran
approved these changes
Nov 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a problem when search backwards with a frequency-based trip.
Issue
Fixes #6102
Unit tests
Added
Documentation
None needed. Pure bug fix only.