Addressing issues #168 related to not supporting multi byte characters #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript strings handle two byte characters as two items which breaks some multi lingual and emoji support.
Motivation and Context
This addresses #168
How Has This Been Tested?
npm test passes. And this has been tested in IE 11 and Chrome.
Types of changes
Mostly this just uses a for...of loop if the browser enables it. Because this is a new feature checks are made to make sure this method is available, and the build tools have been updated to support these changes.
Checklist:
npm run test
and all tests passed green (including code styling checks).