Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Asks the input method to use the vertical candidate window when there is a long candidate. #102

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

zonble
Copy link
Collaborator

@zonble zonble commented Dec 26, 2023

Recently we added the input macro feature. It may cause longer candidates appearing in the candidate window, and it could be hard to use when the window stays horizontal.

The PR lets the candidate to be always vertical when there is a candidate whose length is larger than 8.

src/McBopomofo.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukhnos lukhnos merged commit e14464b into openvanilla:master Dec 26, 2023
3 checks passed
@xatier
Copy link
Contributor

xatier commented Dec 28, 2023

Awesome, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants