feat(macro): add Japanese calendar macro support #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the following macros: DATE_TODAY_MEDIUM_JAPANESE DATE_TOMORROW_MEDIUM_JAPANESE DATE_YESTERDAY_MEDIUM_JAPANESE Also fix a few clang-tidy warnings.
|
screenshots from my local build.
|
lukhnos
approved these changes
Dec 15, 2023
|
I'm putting the merge on hold now. We'll need to have the macOS equivalent of the macros. Then we can sync |
|
no worries, take your time! |
|
@lukhnos I actually wonder if we should also add the macros to
source code: https://github.com/google/mozc/blob/master/src/rewriter/date_rewriter.cc#L85 |
|
@lukhnos, I noticed |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the following macros:
DATE_TODAY_MEDIUM_JAPANESE
DATE_TOMORROW_MEDIUM_JAPANESE
DATE_YESTERDAY_MEDIUM_JAPANESE
Also fix a few clang-tidy warnings.