Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix filtering skill up doc #1238

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

vinnamkim
Copy link
Contributor

Summary

  • There was a mistake and this PR fixes it by removing duplicated filter_func().

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim added this to the 1.6.0 milestone Jan 8, 2024
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Jan 8, 2024
@vinnamkim vinnamkim marked this pull request as ready for review January 8, 2024 05:57
@vinnamkim vinnamkim requested review from a team as code owners January 8, 2024 05:57
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team January 8, 2024 05:57
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb7b6f9) 80.45% compared to head (d3f15e6) 80.49%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1238      +/-   ##
===========================================
+ Coverage    80.45%   80.49%   +0.03%     
===========================================
  Files          268      269       +1     
  Lines        29968    29991      +23     
  Branches      5856     5856              
===========================================
+ Hits         24112    24140      +28     
+ Misses        4490     4487       -3     
+ Partials      1366     1364       -2     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.47% <ø> (?)
windows-2022_Python-3.8 80.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinnamkim vinnamkim merged commit b8c6b94 into openvinotoolkit:develop Jan 8, 2024
6 checks passed
@yunchu yunchu modified the milestones: 1.6.0, 2.0.0 Mar 28, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants