Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enabled support for 'Video' media type in the datumaro format #1491

Conversation

jihyeonyi
Copy link

@jihyeonyi jihyeonyi commented May 7, 2024

Summary

Enabled support for 'Video' media type in the datumaro format to support annotations by video or video range.
Note that the video has a closed interval of [start_frame, end_frame].

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners May 7, 2024 11:32
@jihyeonyi jihyeonyi requested review from itrushkin and removed request for a team May 7, 2024 11:32
@jihyeonyi jihyeonyi marked this pull request as draft May 7, 2024 11:41
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 18 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (releases/1.7.0@b5e2ad8). Click here to learn what that means.

Files Patch % Lines
src/datumaro/components/media.py 85.93% 4 Missing and 5 partials ⚠️
src/datumaro/plugins/data_formats/datumaro/base.py 75.00% 4 Missing and 2 partials ⚠️
...umaro/plugins/data_formats/datumaro_binary/base.py 33.33% 1 Missing and 1 partial ⚠️
...datumaro/plugins/data_formats/datumaro/exporter.py 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.7.0    #1491   +/-   ##
=================================================
  Coverage                  ?   80.78%           
=================================================
  Files                     ?      276           
  Lines                     ?    31489           
  Branches                  ?     6345           
=================================================
  Hits                      ?    25437           
  Misses                    ?     4641           
  Partials                  ?     1411           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.76% <87.23%> (?)
windows-2022_Python-3.10 80.75% <87.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihyeonyi jihyeonyi force-pushed the jihyeony/support_video_annotation_range branch from 34d0cdd to 29754ee Compare May 8, 2024 09:09
@jihyeonyi jihyeonyi marked this pull request as ready for review May 9, 2024 01:21
@jihyeonyi jihyeonyi added this to the 1.7.0 milestone May 9, 2024
@jihyeonyi jihyeonyi marked this pull request as draft May 9, 2024 07:38
@jihyeonyi jihyeonyi marked this pull request as ready for review May 9, 2024 09:17
@wonjuleee wonjuleee changed the base branch from develop to releases/2.0.0 May 9, 2024 12:31
@wonjuleee wonjuleee changed the base branch from releases/2.0.0 to releases/1.7.0 May 9, 2024 23:55
Yi, Jihyeon added 3 commits May 10, 2024 09:01
update video test

fix test errors

change variable name
update unit test for video media and bug fix in __eq__

add unittest for exporter and bugfix

bug fix in checking end_frame in the video media

add missing test file

update license header

fix test error and revise __eq__ of Video media
@jihyeonyi jihyeonyi force-pushed the jihyeony/support_video_annotation_range branch from 3b91952 to d850936 Compare May 10, 2024 00:02
@jihyeonyi jihyeonyi merged commit 4394c6a into openvinotoolkit:releases/1.7.0 May 10, 2024
8 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/support_video_annotation_range branch May 10, 2024 00:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants