Mergeback 1.8.0 to develop #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion type (openvinotoolkit#1533) - Fix to update annotation for `Tabular` and `Caption` annotation type during `Clean` transform - Add comment for `Clean` - Fix typo of function name - Update unit test
### Summary Resolves 145146 and 145169 for datumaro format. * 145146 - When exporting a video several times, it should be saved only once to prevent the video from being overwritten. * 145169 - Exported video paths should be relative from `videos/<subset>` directory. ### How to test Test for 145169 is automatically done by `test_can_save_and_load` @ tests/unit/data_formats/datumaro/test_datumaro_format.py ### Checklist <!-- Put an 'x' in all the boxes that apply --> - [x] I have added unit tests to cover my changes. - [ ] I have added integration tests to cover my changes. - [x] I have added the description of my changes into [CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md). - [ ] I have updated the [documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs) accordingly ### License - [x] I submit _my code changes_ under the same [MIT License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. - [ ] I have updated the license header for each file (see an example below). ```python # Copyright (C) 2024 Intel Corporation # # SPDX-License-Identifier: MIT ```
- Add notebook to show how to clean dataset from kaggle through Datumaro
) Duplicate of openvinotoolkit#1528 but with `releases/1.8.0` base. --------- Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Fixes https://github.com/openvinotoolkit/datumaro/actions/runs/9870800186/job/27258510825. Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1566 +/- ##
===========================================
- Coverage 81.05% 81.03% -0.03%
===========================================
Files 276 276
Lines 32359 32430 +71
Branches 6575 6595 +20
===========================================
+ Hits 26230 26280 +50
- Misses 4684 4696 +12
- Partials 1445 1454 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wonjuleee
approved these changes
Jul 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.