Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change common semantic segmentation dataset detection rule #1572

Conversation

itrushkin
Copy link
Contributor

@itrushkin itrushkin commented Jul 24, 2024

Since Datumaro 1.8, the following folder structure:

# Common semantic segmentation dataset example from OTX tests
.
└── supervised
    ├── test
    │   ├── dataset_meta.json
    │   ├── images
    │   │   ├── 0001.png
    │   │   └── 0002.png
    │   └── masks
    │       ├── 0001.png
    │       └── 0002.png
    ├── train
    │   ├── dataset_meta.json
    │   ├── images
    │   │   ├── 0001.png
    │   │   ├── 0002.png
    │   │   └── 0003.png
    │   └── masks
    │       ├── 0001.png
    │       ├── 0002.png
    │       └── 0003.png
    └── val
        ├── dataset_meta.json
        ├── images
        │   ├── 0001.png
        │   └── 0002.png
        └── masks
            ├── 0001.png
            └── 0002.png

is detected as both common_semantic_segmentation and common_semantic_segmentation_with_subset_dirs. Since they are detected at different levels, the current implementation could not set the higher priority to the second one.

This PR updates detection rules for the common_semantic_segmentation format, searching for requirements in the root directory only.

Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin requested review from a team as code owners July 24, 2024 00:30
@itrushkin itrushkin requested review from jihyeonyi and removed request for a team July 24, 2024 00:30
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (be7f526) to head (10cd400).
Report is 18 commits behind head on develop.

Files Patch % Lines
...ugins/data_formats/common_semantic_segmentation.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1572      +/-   ##
===========================================
- Coverage    81.04%   81.04%   -0.01%     
===========================================
  Files          278      278              
  Lines        32489    32490       +1     
  Branches      6600     6600              
===========================================
  Hits         26330    26330              
  Misses        4706     4706              
- Partials      1453     1454       +1     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <85.71%> (-0.01%) ⬇️
windows-2022_Python-3.10 81.01% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
However, I think related test should be modified, but I guess there's no test affected by this modification. Could you add a related test later?

Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin requested a review from jihyeonyi August 18, 2024 11:48
Copy link

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@itrushkin itrushkin merged commit 5d669f7 into openvinotoolkit:develop Aug 19, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants