-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Change common semantic segmentation dataset detection rule #1572
Change common semantic segmentation dataset detection rule #1572
Conversation
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1572 +/- ##
===========================================
- Coverage 81.04% 81.04% -0.01%
===========================================
Files 278 278
Lines 32489 32490 +1
Branches 6600 6600
===========================================
Hits 26330 26330
Misses 4706 4706
- Partials 1453 1454 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
However, I think related test should be modified, but I guess there's no test affected by this modification. Could you add a related test later?
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Since Datumaro 1.8, the following folder structure:
is detected as both
common_semantic_segmentation
andcommon_semantic_segmentation_with_subset_dirs
. Since they are detected at different levels, the current implementation could not set the higher priority to the second one.This PR updates detection rules for the
common_semantic_segmentation
format, searching for requirements in the root directory only.