Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimize path assignment to handle point cloud in JSON without images #1649

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Optimize path assignment to handle point cloud in JSON without images #1649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2dbb0c
Optimize path assignment with walrus operator
sooahleex Oct 13, 2024
dfc1252
Update CHANGELOG
sooahleex Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
(<https://github.com/openvinotoolkit/datumaro/pull/1599>)
- Update ov ir model for explorer openvino launcher with CLIP ViT-L/14@336px model
(<https://github.com/openvinotoolkit/datumaro/pull/1603>)
- Optimize path assignment to handle point cloud in JSON without images
(<https://github.com/openvinotoolkit/datumaro/pull/1643>)

### Bug fixes
- Fix datumaro format to load visibility information from Points annotations
Expand Down
3 changes: 1 addition & 2 deletions src/datumaro/plugins/data_formats/datumaro/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ def _parse_item(self, item_desc: Dict) -> Optional[DatasetItem]:
pcd_info = item_desc.get("point_cloud")
if media and pcd_info:
raise MediaTypeError(STR_MULTIPLE_MEDIA)
if pcd_info:
pcd_path = pcd_info.get("path")
if pcd_info and (pcd_path := pcd_info.get("path")):
point_cloud = osp.join(self._pcd_dir, self._subset, pcd_path)

related_images = None
Expand Down
Loading