Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix "Total()" is called for dynamic pad #28427

Merged
merged 5 commits into from
Feb 11, 2025

Conversation

yuanxion
Copy link
Contributor

@yuanxion yuanxion commented Jan 14, 2025

Details:

  • Fix dynamic pad checking for "Total" call when it is runtime

Tickets:

@yuanxion yuanxion requested review from a team as code owners January 14, 2025 08:08
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Jan 14, 2025
@yuanxion
Copy link
Contributor Author

After comment out the "is_dynamic" checking for Pad, the dynamic model running does not crash when running on iGPU.

(Though the final generated image is all black, it may not be related to this PR because this all black image is also generated after reshaping this dynamic model to static)

image

@yuanxion yuanxion requested a review from yeonbok January 14, 2025 08:23
@yuanxion
Copy link
Contributor Author

yuanxion commented Jan 26, 2025

After solving the "Total()" calling failure with commit e432370, 1 issue is the output result is still all-black image when running demo with OpenVINO models (quantized) on iGPU.
image

Checked that these OpenVINO models on CPU can get correct result.
image

@yuanxion yuanxion force-pushed the fix-stable-cascade-image branch from e432370 to 31f9f4d Compare January 26, 2025 09:57
Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
…is runtime

Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
@yuanxion yuanxion force-pushed the fix-stable-cascade-image branch from 31f9f4d to de6ec66 Compare February 2, 2025 23:52
Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
@yuanxion
Copy link
Contributor Author

yuanxion commented Feb 6, 2025

Fixed gemm_gpu_tests.dynamic_padding_all_dim testcase failure of gemm dynamic padding, by limiting changes only to fully_connected with commit d9b845c.

Signed-off-by: yuan.xiong <yuan.xiong@intel.com>
@p-durandin p-durandin added this pull request to the merge queue Feb 11, 2025
Merged via the queue into openvinotoolkit:master with commit 81d712b Feb 11, 2025
168 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category: GPU OpenVINO GPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants