Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CPU] Fix google-default-arguments clang-tidy remarks #28772

Merged

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 31, 2025

Details:

  • Fix "google-default-arguments" issues reported by clang-tidy
  • Enable "google-default-arguments" clang-tidy checks on CI by default
  • Introduce "emit_code_impl" in JIT emitters to avoid default arguments in virtual methods

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners January 31, 2025 19:05
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 31, 2025
@EgorDuplensky
Copy link
Contributor

EgorDuplensky commented Feb 5, 2025

@dmitry-gorokhov Could you please take a look
google-default-arguments is fixed in scope of separate commit since it was not so straightforward to resolve.

@dmitry-gorokhov dmitry-gorokhov added this to the 2025.1 milestone Feb 12, 2025
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 12, 2025
Merged via the queue into openvinotoolkit:master with commit d04fd6e Feb 12, 2025
238 of 239 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants