Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[TF FE] feat: implement complex type support for selectv2 #28773

Merged
merged 7 commits into from
Feb 2, 2025
Merged

[TF FE] feat: implement complex type support for selectv2 #28773

merged 7 commits into from
Feb 2, 2025

Conversation

11happy
Copy link
Contributor

@11happy 11happy commented Feb 1, 2025

Overview:
This pull request fixes #28678.

Testing:

  • Tested the implementation. Verified other implementations remain unaffected.
    Screenshot from 2025-02-01 09-00-09

CC:

@11happy
feat: implement complex type support for selectv2
f26f617 
Signed-off-by: 11happy <soni5happy@gmail.com>
@11happy 11happy requested a review from a team as a code owner February 1, 2025 03:36
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Feb 1, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Feb 1, 2025
rkazants
rkazants reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. Just fix a few comments

@rkazants rkazants added this to the 2025.1 milestone Feb 1, 2025
11happy and others added 3 commits February 1, 2025 18:06
@11happy @rkazants
Update tests/layer_tests/tensorflow_tests/test_tf_SelectV2.py
2b1bfe7 
Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
@11happy @rkazants
Update tests/layer_tests/tensorflow_tests/test_tf_SelectV2.py
9b59f8a 
Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
@11happy
refactor: use unsqueeze
faf3324 
Signed-off-by: 11happy <soni5happy@gmail.com>
@rkazants
Copy link
Member

rkazants commented Feb 1, 2025

build_jenkins

@rkazants
Copy link
Member

rkazants commented Feb 1, 2025

build_jenkins

@rkazants rkazants self-assigned this Feb 1, 2025
@rkazants
Copy link
Member

rkazants commented Feb 1, 2025

@11happy, please fix the build: https://github.com/openvinotoolkit/openvino/actions/runs/13090731752/job/36527176177?pr=28773

@11happy
fix: include missing unsqueeze header
7760ead 
Signed-off-by: 11happy <soni5happy@gmail.com>
@11happy
Merge remote-tracking branch 'refs/remotes/origin/selectv2.complex' i…
a5099de 
…nto selectv2.complex

merge commit
@11happy
Copy link
Contributor Author

11happy commented Feb 1, 2025

@11happy, please fix the build: https://github.com/openvinotoolkit/openvino/actions/runs/13090731752/job/36527176177?pr=28773

I have added the unsqueeze header which was causing the build to fail.
thank you

@rkazants
Copy link
Member

rkazants commented Feb 2, 2025

build_jenkins

@rkazants rkazants enabled auto-merge February 2, 2025 08:40
@rkazants rkazants added this pull request to the merge queue Feb 2, 2025
Merged via the queue into openvinotoolkit:master with commit 4c01a98 Feb 2, 2025
182 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rkazants rkazants rkazants approved these changes

Assignees

@rkazants rkazants

Labels
category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support complex tensors for SelectV2 operations
3 participants
@11happy @rkazants @sys-openvino-ci