[GPU] Use sdpa-micro kernel for prefill processing in PagedAttention #29137
+436
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshlyapn
force-pushed
the
paged_attention_micro_sdpa_prefill
branch
3 times, most recently
from
e6b2b07 to
c19414b
Compare
sshlyapn
force-pushed
the
paged_attention_micro_sdpa_prefill
branch
from
c19414b to
8638537
Compare
| } | ||
|
|
||
| std::vector<layout> get_internal_buffer_layouts_impl() const override { | ||
| std::vector<kernel_selector::InternalBuffer> get_internal_buffers_desc() const { |
There was a problem hiding this comment.
I'd say that extended buffer descriptor can be returned from get_internal_buffer_layouts_impl and used in the primitive_inst directly. IMO, current solution with separate methods to query layouts and lockable buffers doesn't look good. Please consider changing that in the future
|
|
||
| auto& pa_inst = reinterpret_cast<paged_attention_inst&>(inst); | ||
| pa_inst.query_block_size = get_query_block_size(PagedAttentionStage::PREFILL); | ||
| pa_inst.use_micro_sdpa = use_micro_sdpa; |
There was a problem hiding this comment.
Can we avoid having implementation specific attributes in primitive_inst? Maybe the code from paged_attention_inst::on_execute() can be moved to primitive impl itself?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: