Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Temporary fix for jsonargparse issue on Python3.11.9 #3291

Merged

Conversation

vinnamkim
Copy link
Contributor

Summary

Our CI unit test on Python 3.11 started not working today (Python 3.10 is fine).

This seems because Python 3.11.9 is released today (Apr. 08): Python Insider: Python 3.11.9 is now available and jsonargparse is affected by this update: omni-us/jsonargparse#484

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 37165e0 into openvinotoolkit:develop Apr 9, 2024
13 checks passed
@vinnamkim vinnamkim deleted the fix-py3-11-9-jsonargparse-issue branch April 9, 2024 04:42
eunwoosh pushed a commit to eunwoosh/training_extensions that referenced this pull request Apr 9, 2024
…#3291)

Update GH action workflow

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
eunwoosh added a commit that referenced this pull request Apr 9, 2024
…ch (#3294)

Temporary fix for jsonargparse issue on Python3.11.9 (#3291)

Update GH action workflow

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Co-authored-by: Vinnam Kim <vinnam.kim@intel.com>
@vinnamkim vinnamkim mentioned this pull request Apr 18, 2024
8 tasks
vinnamkim added a commit that referenced this pull request May 17, 2024
* Fix

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Fix

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Fix

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Fix

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Fix cls models not to have loss_callable

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

* Revert integration gh action modification

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>

---------

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants