Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update inst-seg model export to include feature vector and saliency map #4053

Merged

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Oct 22, 2024

Summary

This PR fixed explain model for MaskRCNN/RTMDet-Inst/MaskRCNN-TV instance segmentation model

  • Export feature vector when explain_mode is ON
  • Export dummy saliency map when explain_mode is ON (saliency map is handled in MAPI)
  • Add MaskRCNN-TV explainable feature for PyTorch model

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

sovrasov
sovrasov previously approved these changes Oct 22, 2024
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Oct 22, 2024
sovrasov
sovrasov previously approved these changes Oct 22, 2024
@sovrasov
Copy link
Contributor

@eugene123tw thanks for the prompt fix! To address the issue in Geti 2.5 the changes should target OTX 2.2 release branch as well

chuneuny-emily
chuneuny-emily previously approved these changes Oct 23, 2024
@chuneuny-emily chuneuny-emily changed the base branch from develop to releases/2.2.0 October 23, 2024 01:09
@chuneuny-emily chuneuny-emily dismissed stale reviews from sovrasov and themself October 23, 2024 01:09

The base branch was changed.

@chuneuny-emily chuneuny-emily changed the base branch from releases/2.2.0 to develop October 23, 2024 01:10
@harimkang
Copy link
Contributor

i create PR that include same changes to 2.2 (#4056)

@eugene123tw eugene123tw enabled auto-merge (squash) October 23, 2024 13:04
@eugene123tw eugene123tw disabled auto-merge October 23, 2024 13:29
@eugene123tw eugene123tw changed the title Update MRCNN model export to include feature vector and saliency map Update inst-seg model export to include feature vector and saliency map Oct 23, 2024
eunwoosh
eunwoosh previously approved these changes Oct 24, 2024
@sungchul2
Copy link
Contributor

@eugene123tw could you describe the purpose and changes of this PR in Summary?

@eugene123tw eugene123tw requested review from sovrasov, sungchul2 and eunwoosh and removed request for sovrasov October 24, 2024 09:50
@eugene123tw eugene123tw merged commit 0d87ca6 into openvinotoolkit:develop Oct 25, 2024
20 of 21 checks passed
@eugene123tw eugene123tw deleted the eugene/inst-seg-explain branch October 25, 2024 12:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
DOC Improvements or additions to documentation OTX 2.0 TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants