feat: Lazily call setup function for moduli and curves on first use #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
feat/lazy-setup
branch
from
3b6f6bb to
a05cfd9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
feat/lazy-setup
branch
2 times, most recently
from
a6a58ae to
438d810
Compare
Avaneesh-axiom
changed the base branch from
main
to
feat/binding-primitive-libs
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
feat/lazy-setup
branch
from
438d810 to
6e80926
Compare
This comment has been minimized.
This comment has been minimized.
Avaneesh-axiom
force-pushed
the
feat/lazy-setup
branch
from
6e80926 to
46b55bc
Compare
This comment has been minimized.
This comment has been minimized.
| setup_all_moduli(); | ||
| setup_all_complex_extensions(); | ||
| setup_all_curves(); | ||
| // TODO: Since we don't explicitly call setup functions anymore, we should rewrite this test |
There was a problem hiding this comment.
don't forget this TODO before we merge feature branch
This comment has been minimized.
This comment has been minimized.
| @@ -110,6 +113,7 @@ pub fn complex_declare(input: TokenStream) -> TokenStream { | |||
| } | |||
| #[cfg(target_os = "zkvm")] | |||
| { | |||
| Self::assert_is_setup(); | |||
There was a problem hiding this comment.
side comment, technically shouldn't it be assert_is_set_up? not worth changing though
extensions/pairing/tests/programs/openvm_init_fp12_mul_bls12_381.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… complex_setup_extern_func
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
Apr 29, 2025
Commit: b39fd2e |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to manually call
setup_*at the start of main for the moduli and curves. Instead, setup is automatically done on first use of each modulus or curve.Depends on #1596