Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Add feature to clean up iptable rules after test is done or topology #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mingchik
Copy link

@mingchik mingchik commented Oct 2, 2019

tears down

Fix:

  1. Add feature to skip retries (3) when nmcli disabled (state = NoneType)
  2. Cleans iptables after test is down or tear down topology (happy-state-delete)
  3. Able to handle existing iptables rules, will not add again.
  4. Remove all the existed iptables rules after tear down.
  5. Raises meaningful error message when insertion failed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mingchik
Copy link
Author

mingchik commented Oct 2, 2019

@googlebot I signed it!

@robszewczyk
Copy link
Member

Please fix the commit message:

one line for the title, followed by an empty line

description of the changes, markdown is supported within the commit message. In particular, please improve the readability of the message:

  • use parallel grammatical construction for all list entries (e.g. 1. Skip entries when nlcli is disabled, 2. Clean up iptables after test teardown , ... 5. Raise meaningful exceptions ...)
  • ensure proper grammar

After addressing the commit message and the code-related comments, please force push to branch.

happy/HappyInternet.py Outdated Show resolved Hide resolved
happy/HappyInternet.py Outdated Show resolved Hide resolved
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mingchik mingchik force-pushed the feature/clean_added_iptables_rules branch 3 times, most recently from 0a67c7b to 66310d8 Compare October 3, 2019 23:48
Fixed:
 - Skip retries (3) when nmcli disabled. (state = NoneType)
 - Clean iptables after tearing down happy topology. (happy-state-delete)
 - Handle duplicate iptables rules insertion.
 - Remove all the existing iptables rules after tearing down topology.
 - Raise meaningful error message when insertion failed.
@mingchik mingchik force-pushed the feature/clean_added_iptables_rules branch from 66310d8 to 7268402 Compare October 3, 2019 23:54
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants