[docs] Added tutorial for WPA Enterprise #184 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/184-wpa-enterprise
branch
from
1ee4e72 to
93025a4
Compare
pandafy
force-pushed
the
issues/184-wpa-enterprise
branch
from
93025a4 to
a0d06a4
Compare
pandafy
force-pushed
the
issues/184-wpa-enterprise
branch
from
c8e5d11 to
7e2c779
Compare
nemesifier
requested changes
May 23, 2024
tutorials/wpa-enterprise.rst
Outdated
Comment on lines
15
to
17
| Enabled OpenWISP RADIUS | ||
| ~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
There was a problem hiding this comment.
Suggested change
| Enabled OpenWISP RADIUS | |
| ~~~~~~~~~~~~~~~~~~~~~~~ | |
| Enable OpenWISP RADIUS | |
| ~~~~~~~~~~~~~~~~~~~~~~ |
tutorials/wpa-enterprise.rst
Outdated
| "mode": "0700", | ||
| "contents": "#!/bin/sh\n\n# Ensure radio0 is enabled \nuci set wireless.radio0.disabled='0'\nuci commit wireless" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Indentation seems inconsistent: here it's 2 spaces, above is 4. Make it consistent.
tutorials/wpa-enterprise.rst
Outdated
| "maclist": [] | ||
| }, | ||
| "type": "wireless", | ||
| "name": "wlan0", |
There was a problem hiding this comment.
I suggest renaming this to avoid potential conflicts with other templates which may be assigned simultaneously to a device, wlan0 is very common. I should have done this also for the mesh tutorial, but it occurred to me only now when I thought I would try this template simultaneously with the mesh template, but it won't work. Please update the demo fixture as well.
nemesifier
requested changes
May 29, 2024
nemesifier
requested changes
Jul 1, 2024
pandafy
force-pushed
the
issues/184-wpa-enterprise
branch
from
9fa57aa to
ae3fd69
Compare
nemesifier
approved these changes
Jul 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184