Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[fix] Use version branch of openwisp-docs #218 #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix] Use version branch of openwisp-docs #218 #221

wants to merge 2 commits into from

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Feb 26, 2025

Fixes #218

@pandafy pandafy force-pushed the issues/218-docs-branch branch 2 times, most recently from 996e09f to 8f2cb36 Compare February 26, 2025 15:42
pandafy
pandafy commented Feb 26, 2025
View reviewed changes
build.py
Comment on lines -241 to -250
subprocess.run(
['git', 'remote', 'set-branches', 'origin', branch],
cwd=clone_path,
check=True,
)
subprocess.run(
['git', 'fetch', '--update-shallow', 'origin', branch],
cwd=clone_path,
check=True,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unnecessarily slowing down the CI build. Now, the complete repository is downloaded.

nemesifier
nemesifier requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use "staging_dir" instead of "openwisp-docs" for the intermediate directory and please add a summary of how the build process in the README.

@pandafy pandafy force-pushed the issues/218-docs-branch branch from 8f2cb36 to 3f22b89 Compare February 28, 2025 10:19
@pandafy pandafy force-pushed the issues/218-docs-branch branch from 3f22b89 to f533516 Compare February 28, 2025 10:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nemesifier nemesifier nemesifier requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
OpenWISP Contributor's Board
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Build script always uses the master branch of openwisp-docs for all OpenWISP versions
2 participants
@pandafy @nemesifier