tvheadend: bind to LAN IP by default #17896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If config parameter is not set, tvheadend will bind to LAN IP address by default. Fixes issue #16500 without requiring user modifications to config file. It's also more secure if firewall becomes disabled. Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
|
Tested successful both on RaspberryPi1(LAN-ip client active/passive) and Zyxel P-2812HNU-F1(normal router WAN/LAN config) running OpenWrt 21.02.2 with Tvheadend package are able to instantly detect SATIP-tuner (fritzbox 6490 v07.29, with static ip-address matching the LAN interface subnet of the OpenWrt devices) with this patch. PS: May also request @BKPepe to backport this for 21.02.x branch? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: not tested, compilation is not affected
Run tested: r18404
Description:
If config parameter is not set, tvheadend will bind to LAN IP address by default. If IP not found, the switch is not added and tvheadend will bind to 0.0.0.0, as it is now.
Fixes issue #16500 without requiring user to edit the config file. It's also more secure if firewall becomes disabled. There are no drawbacks that I can think of.