-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
youtube-dl: drop package, yt-dlp: add package #18515
Conversation
Yes, thank you. |
multimedia/yt-dlp/Makefile
Outdated
+python3-xml \ | ||
+python3-codecs \ | ||
+python3-ctypes \ | ||
+python3-setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these deps all?
https://cgit.freebsd.org/ports/tree/www/yt-dlp/Makefile#n11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed setuptools because they don't use it and added relevant python3 stdlib dependencies.
Dependencies in distributions are all optional. On my computer, I can download a youtube video with yt-dlp with just python3 installed. If I wanted the best audio and video quality, I would have to install ffmpeg because audio and video files need to be downloaded separately and then combined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Void Linux (where I maintain yt-dlp) and Alpine Linux only have python in dependencies, Arch and maybe other distributions only have python-certifi (which is also optional) in dependencies.
545f01c
to
ad104a8
Compare
I don't see why youtube-dl has to be dropped for yt-dlp to be added. I checked Debian/Ubuntu, Fedora, and Arch Linux, they have packages for both. |
I am in favor to drop |
@BKPepe I think users may want to use the "original" youtube-dl and the project appears alive again with a new maintainer, but it's your package so you get to decide 😂 |
Hmm. That's not very helpful, though! My problem is that I don't want really to maintain both versions. :-( On the other hand, sometimes there are added packages used by just one user, which is terrible. Right now, I see yt-dlp as a replacement for youtube-dl, which does not release as often as it did in the past. We can re-introduce youtube-dl later if someone wants, too. Fewer packages to maintain, then better for me. Maybe, it will help if in the commit description in dropping package for youtube-dl there will be the same what is in the PR description to have a better history. |
Yes, just create a symlink and be done with it. |
I think that pretending that yt-dlp is youtube-dl is a bad idea, it's a fork and mostly compatible, but it's not youtube-dl, for example the config location is ~/.config/yt-dlp, not ~/.config/youtube-dl and if the user installs youtube-dl and uses the youtube-dl command, they will be surprised that the config location is suddenly different. |
If the user installed a package called "yt-dlp", they can probably guess the command is called I suppose this could use the |
@paper42 |
youtube-dl is still maintained, but moves very slowly and many other distributions instead package an active fork, yt-dlp. Signed-off-by: Michal Vasilek <michal.vasilek@nic.cz>
Signed-off-by: Michal Vasilek <michal.vasilek@nic.cz>
Maintainer: me, @BKPepe
Compile tested: armv7, Turris Omnia, OpenWrt 21.02
Run tested: armv7, Turris Omnia, OpenWrt 21.02
Description:
youtube-dl is still maintained, but moves very slowly and many other distributions instead package an active fork, yt-dlp.
@BKPepe would you be ok with me adopting this package?
cc @diizzyy