Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve yurthub get pods for cloud node #1514

Merged

Conversation

JameKeal
Copy link
Member

@JameKeal JameKeal commented Jun 5, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

User use yurtstaticset to upgrade pod, the worker pod will check the static pod status using restful apis for yurthub like: /pods, when yurthub running in the cloud, it will not return pods because the yurthub not cache info for cloud mode.

So yurthub is cloud mode, when get pods, it can use informer cache to return pod list.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

User use yurtstaticset to upgrade pod, the worker pod will check the static pod status using restful apis for yurthub like: /pods, when yurthub running in the cloud, it will not return pods because the yurthub not cache info for cloud mode.

So yurthub is cloud mode, when get pods, it can use informer cache to return pod list.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Jun 5, 2023
@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #1514 (e4b4e99) into master (1e0eb47) will increase coverage by 0.21%.
The diff coverage is 0.00%.

❗ Current head e4b4e99 differs from pull request most recent head c663991. Consider uploading reports for the commit c663991 to get more accurate results

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   50.74%   50.96%   +0.21%     
==========================================
  Files         131      133       +2     
  Lines       15576    15680     +104     
==========================================
+ Hits         7904     7991      +87     
- Misses       6951     6953       +2     
- Partials      721      736      +15     
Flag Coverage Δ
unittests 50.96% <0.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/yurthub/app/config/config.go 52.41% <0.00%> (-1.20%) ⬇️
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)

... and 40 files with indirect coverage changes

@JameKeal JameKeal force-pushed the improve-yurthub-get-pods-for-cloud branch from a42e396 to e895281 Compare June 8, 2023 06:45
@JameKeal JameKeal requested a review from rambohe-ch June 8, 2023 06:45
@JameKeal JameKeal force-pushed the improve-yurthub-get-pods-for-cloud branch from ca52903 to 5f603e2 Compare June 8, 2023 07:01
@JameKeal JameKeal force-pushed the improve-yurthub-get-pods-for-cloud branch from e4b4e99 to c663991 Compare June 19, 2023 03:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@JameKeal JameKeal requested a review from rambohe-ch June 19, 2023 03:05
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 19, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 19, 2023
@openyurt-bot openyurt-bot merged commit 89abaff into openyurtio:master Jun 19, 2023
@JameKeal JameKeal deleted the improve-yurthub-get-pods-for-cloud branch June 20, 2023 01:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants