-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
improve yurthub get pods for cloud node #1514
improve yurthub get pods for cloud node #1514
Conversation
@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 50.74% 50.96% +0.21%
==========================================
Files 131 133 +2
Lines 15576 15680 +104
==========================================
+ Hits 7904 7991 +87
- Misses 6951 6953 +2
- Partials 721 736 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a42e396
to
e895281
Compare
ca52903
to
5f603e2
Compare
e4b4e99
to
c663991
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JameKeal, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
User use yurtstaticset to upgrade pod, the worker pod will check the static pod status using restful apis for yurthub like: /pods, when yurthub running in the cloud, it will not return pods because the yurthub not cache info for cloud mode.
So yurthub is cloud mode, when get pods, it can use informer cache to return pod list.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note