-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: remove watch nodepool in service topology controller #1554
feat: remove watch nodepool in service topology controller #1554
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
As discussed in #1553 , The efficiency of service topology feature can be improved if nodepool list/watch is removed.
moreover, nodepool list/watch is a dummy function for service topology controller.
so i want to remove list/watch nodepool function in service topology controller.
Which issue(s) this PR fixes:
Fixes #1553
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note