Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add cpu limit for yurthub #1609

Merged

Conversation

huweihuang
Copy link
Contributor

@huweihuang huweihuang commented Jul 12, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

there is not cpu limit for yurthub, it will cause the yurthub cost too much CPU, causing high node load and affecting other services.

Which issue(s) this PR fixes:

Fixes ##1605

Special notes for your reviewer:

/assign @rambohe-ch

@openyurt-bot
Copy link
Collaborator

@huweihuang: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##1605

Special notes for your reviewer:

@rambohe-ch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot requested review from SataQiu and YTGhost July 12, 2023 04:08
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huweihuang
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jul 12, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1609 (6a75a4d) into master (7f41a78) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
+ Coverage   51.42%   51.43%   +0.01%     
==========================================
  Files         134      134              
  Lines       15947    15947              
==========================================
+ Hits         8200     8202       +2     
+ Misses       7001     7000       -1     
+ Partials      746      745       -1     
Flag Coverage Δ
unittests 51.43% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch
Copy link
Member

/approve

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants