Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add raven l7 dns controller #1658

Merged

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Aug 16, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/kind feature
/sig network

What this PR does / why we need it:

This controller maintains a configmap record that requests across network domains are forwarded to the Gateway node by the Raven Agent

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A configmap named edge-tunnel-nodes is mounted to CoreDNS using the hosts plugin, the DNS controller is responsible for maintaining this configmap and maps requests of acrossing pools to the x-raven-proxy-internal-svc address

other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind enhancement
/kind feature
/sig network

What this PR does / why we need it:

This controller maintains a configmap record that requests across network domains are forwarded to the Gateway node by the Raven Agent

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Aug 16, 2023
@River-sh River-sh force-pushed the feature_gateway_dns_controller branch from baecdce to 90a0ee9 Compare August 16, 2023 06:08
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1658 (919bcff) into master (efe75d5) will decrease coverage by 0.25%.
Report is 1 commits behind head on master.
The diff coverage is 33.03%.

@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
- Coverage   52.32%   52.07%   -0.25%     
==========================================
  Files         154      156       +2     
  Lines       17637    17858     +221     
==========================================
+ Hits         9228     9299      +71     
- Misses       7582     7716     +134     
- Partials      827      843      +16     
Flag Coverage Δ
unittests 52.07% <33.03%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...yurtmanager/controller/raven/dns/dns_controller.go 30.06% <30.06%> (ø)
...nager/controller/raven/dns/dns_enqueue_handlers.go 41.37% <41.37%> (ø)

... and 1 file with indirect coverage changes

@River-sh River-sh force-pushed the feature_gateway_dns_controller branch 4 times, most recently from 3fa64a8 to 8008dd1 Compare August 18, 2023 03:01
@River-sh River-sh force-pushed the feature_gateway_dns_controller branch from 8008dd1 to 919bcff Compare August 18, 2023 03:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch merged commit 68d4079 into openyurtio:master Aug 24, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BSWANG, rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants