Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add yurtappset v1beta1 proposal #1890

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

luc99hen
Copy link
Member

@luc99hen luc99hen commented Jan 2, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67e1485) 52.20% compared to head (dadfdae) 52.18%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   52.20%   52.18%   -0.02%     
==========================================
  Files         172      172              
  Lines       20844    20882      +38     
==========================================
+ Hits        10881    10898      +17     
- Misses       8999     9017      +18     
- Partials      964      967       +3     
Flag Coverage Δ
unittests 52.18% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luc99hen luc99hen force-pushed the yurtappset_v1beta1_propasal branch 2 times, most recently from fb06bae to a9aafe1 Compare January 10, 2024 06:00
@luc99hen luc99hen force-pushed the yurtappset_v1beta1_propasal branch from a9aafe1 to dadfdae Compare January 10, 2024 06:23
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@luc99hen
Copy link
Member Author

24.1.10 Community Discussion Results:

  1. Before using YurtAppSet, when creating node pools, it is recommended that users plan node pool labels in advance to facilitate subsequent node pool management. @gnunu
  2. Is it better to introduce a new CRD rather than upgrading YurtAppSet? @Congrool
  • Pros: no need to care about YurtAppSet v1alpha1 dependencies
  • Cons: need to propose a new CRD name

@rambohe-ch
Copy link
Member

@luc99hen @gnunu @Congrool I want to add conclusions that we had made on the meeting for these two points.

24.1.10 Community Discussion Results:

  1. Before using YurtAppSet, when creating node pools, it is recommended that users plan node pool labels in advance to facilitate subsequent node pool management. @gnunu

A common label will be added to nodepool in the webhook when new nodepool is created, so end user can use this common label to select all nodepools in the YurtAppSet without managing the labels of nodepool.

  1. Is it better to introduce a new CRD rather than upgrading YurtAppSet? @Congrool
  • Pros: no need to care about YurtAppSet v1alpha1 dependencies
  • Cons: need to propose a new CRD name

because YurtAppSet v1beta1 can keep part consistency with YurtAppSet v1alpha1, at the same time, YurtAppSet will cover the feature of YurtAppDamon and YurtAppOverrider. I don't import a new CRD for the YurtAppSet v1beta1.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 12, 2024
@rambohe-ch rambohe-ch merged commit d7d5ef7 into openyurtio:master Jan 12, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
Co-authored-by: luchen <cl382465@alibaba-inc.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants