-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add yurtappset v1beta1 proposal #1890
add yurtappset v1beta1 proposal #1890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
- Coverage 52.20% 52.18% -0.02%
==========================================
Files 172 172
Lines 20844 20882 +38
==========================================
+ Hits 10881 10898 +17
- Misses 8999 9017 +18
- Partials 964 967 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fb06bae
to
a9aafe1
Compare
a9aafe1
to
dadfdae
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
24.1.10 Community Discussion Results:
|
@luc99hen @gnunu @Congrool I want to add conclusions that we had made on the meeting for these two points.
A common label will be added to nodepool in the webhook when new nodepool is created, so end user can use this common label to select all nodepools in the YurtAppSet without managing the labels of nodepool.
because YurtAppSet v1beta1 can keep part consistency with YurtAppSet v1alpha1, at the same time, YurtAppSet will cover the feature of YurtAppDamon and YurtAppOverrider. I don't import a new CRD for the YurtAppSet v1beta1. |
/lgtm |
Co-authored-by: luchen <cl382465@alibaba-inc.com>
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note