Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: improve configuration of concurrent pod-binding workers (#1917) #1923

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

huangchenzhao
Copy link
Member

What type of PR is this?

/kind good-first-issue
/kind feature

What this PR does / why we need it:

improve the configuration of concurrent pod-binding worker in yurt-manager component

Which issue(s) this PR fixes:

Fixes #1917

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (a6b0442) 52.17% compared to head (7744c0f) 52.17%.

Files Patch % Lines
...urtcoordinator/podbinding/podbinding_controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1923      +/-   ##
==========================================
- Coverage   52.17%   52.17%   -0.01%     
==========================================
  Files         172      172              
  Lines       20878    20876       -2     
==========================================
- Hits        10894    10892       -2     
  Misses       9017     9017              
  Partials      967      967              
Flag Coverage Δ
unittests 52.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

/lgtm

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 16, 2024
@rambohe-ch rambohe-ch merged commit 81d21b7 into openyurtio:master Jan 16, 2024
12 of 13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]improve configuration of concurrent pod-binding workers
2 participants