Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

don't cache csr and sar resource in yurthub #1949

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

don't cache csr and sar resource on edge nodes

Which issue(s) this PR fixes:

Fixes #1880

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e5d8fc) 52.04% compared to head (0e5774e) 52.34%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1949      +/-   ##
==========================================
+ Coverage   52.04%   52.34%   +0.29%     
==========================================
  Files         174      173       -1     
  Lines       21213    21010     -203     
==========================================
- Hits        11040    10997      -43     
+ Misses       9199     9062     -137     
+ Partials      974      951      -23     
Flag Coverage Δ
unittests 52.34% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@YTGhost YTGhost merged commit d136cc1 into openyurtio:master Feb 20, 2024
13 checks passed
zyjhtangtang pushed a commit to zyjhtangtang/openyurt that referenced this pull request Apr 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]yurthub doesn't need to cache certificatesigningrequests and subjectaccessreviews resource
2 participants