aggregated annotations and labels. #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2027 +/- ##
==========================================
+ Coverage 55.32% 55.37% +0.05%
==========================================
Files 183 185 +2
Lines 17835 17821 -14
==========================================
+ Hits 9867 9869 +2
+ Misses 6942 6934 -8
+ Partials 1026 1018 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rambohe-ch
reviewed
Apr 18, 2024
pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/map_utils.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Apr 18, 2024
pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/aggregatetolabels.go
Show resolved
Hide resolved
rambohe-ch
reviewed
Apr 18, 2024
pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/aggregatetoannotations.go
Show resolved
Hide resolved
rambohe-ch
reviewed
Apr 22, 2024
pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/map_utils.go
Outdated
Show resolved
Hide resolved
rambohe-ch
reviewed
Apr 22, 2024
pkg/yurtmanager/controller/loadbalancerset/loadbalancerset/map_utils.go
Outdated
Show resolved
Hide resolved
|
rambohe-ch
approved these changes
Apr 22, 2024
|
/lgtm |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Aggregate labels and annotations from poolservices status to service.
Does this PR introduce a user-facing change?