Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: create abspath dir in case that contents is empty #2164

Merged
merged 4 commits into from
Oct 20, 2024

Conversation

vie-serendipity
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind bug

What this PR does / why we need it:

fix bug of issue 2133

Which issue(s) this PR fixes:

Fixes #2133

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

other Note

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.92%. Comparing base (3713163) to head (5163848).
Report is 39 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurthub/storage/disk/storage.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   56.09%   58.92%   +2.82%     
==========================================
  Files         186      211      +25     
  Lines       18092    19010     +918     
==========================================
+ Hits        10149    11201    +1052     
+ Misses       6910     6723     -187     
- Partials     1033     1086      +53     
Flag Coverage Δ
unittests 58.92% <0.00%> (+2.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch
Copy link
Member

@vie-serendipity would you like to post a pull request to fix Trivy Scan error. you can check the error Details and find the error reason.

@vie-serendipity
Copy link
Member Author

@rambohe-ch ok

@vie-serendipity
Copy link
Member Author

/rerun

@vie-serendipity
Copy link
Member Author

It looks like the download of the vulnerability database failed due to some network issues. But after I tried again, everything is working fine now.

@vie-serendipity
Copy link
Member Author

/PTAL @rambohe-ch

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Oct 18, 2024
@rambohe-ch
Copy link
Member

/LGTM

Copy link

@rambohe-ch rambohe-ch merged commit f2869f7 into openyurtio:master Oct 20, 2024
12 of 13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved lgtm lgtm
Projects
None yet
2 participants