Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix: update clusterrole and certificate for yurt-tunnel-server and fix kubeconfig path error for yurtctl #323

Merged
merged 1 commit into from
May 26, 2021

Conversation

rambohe-ch
Copy link
Member

@rambohe-ch rambohe-ch commented May 26, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. update clusterrole of yurt-tunnel-server in order to support dns mode
  2. add x-tunnel-server-internal-svc info into yurt-tunnel-server certificate
  3. fix kubeconfig path error for yurtctl covert edgenode cmd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Fei-Guo
/assign @Peeknut

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

  1. update clusterrole of yurt-tunnel-server in order to support dns mode
  2. add x-tunnel-server-internal-svc info into yurt-tunnel-server certificate
  3. fix kubeconfig path error for yurtctl covert edgenode cmd

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @Fei-Guo
/assign @Peeknut

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added kind/bug kind/bug size/L size/L: 100-499 labels May 26, 2021
@openyurt-bot openyurt-bot requested review from Fei-Guo and yixingjia May 26, 2021 03:49
@openyurt-bot openyurt-bot added the approved approved label May 26, 2021
@Fei-Guo
Copy link
Member

Fei-Guo commented May 26, 2021

/approve
/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label May 26, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit d977d04 into openyurtio:master May 26, 2021
@rambohe-ch rambohe-ch deleted the bug-fix branch May 27, 2021 06:26
@openyurtio openyurtio deleted a comment from Peeknut Jun 17, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants