Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add parameter verification of specified cloud node. #336

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add parameter verification of specified cloud node. #336

merged 1 commit into from
Jun 4, 2021

Conversation

yanyhui
Copy link
Member

@yanyhui yanyhui commented Jun 4, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

This is the solution
no cloud node is specified when executing the yurtctl convert command, but the program does not report an error.

Which issue(s) this PR fixes:

Fixes #335

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@yanyhui: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #335

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jun 4, 2021
@kadisi
Copy link
Member

kadisi commented Jun 4, 2021

/kind bug

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jun 4, 2021
@rambohe-ch
Copy link
Member

/assign @Peeknut

@Peeknut
Copy link
Member

Peeknut commented Jun 4, 2021

lgtm

@Fei-Guo
Copy link
Member

Fei-Guo commented Jun 4, 2021

/approve
/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fei-Guo, yanyhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jun 4, 2021
@openyurt-bot openyurt-bot merged commit db2d5ec into openyurtio:master Jun 4, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
6 participants