Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

enhancement: skip ensure iptables rule error for yurthub #458

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

Iptables rules are not requirement for clients(like kubelet, kube-proxy etc.) access yurthub, we can skip the iptables ensure error and continue to ensure remained iptables rules.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

Iptables rules are not requirement for clients(like kubelet, kube-proxy etc.) access yurthub, we can skip the iptables ensure error and continue to ensure remained iptables rules.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added approved approved size/XS size/XS: 0-9 labels Sep 8, 2021
@Fei-Guo
Copy link
Member

Fei-Guo commented Sep 8, 2021

Can you explain the problem of current code which fails earlier? The error seems indicating the host is not in expected state.

@rambohe-ch
Copy link
Member Author

Can you explain the problem of current code which fails earlier? The error seems indicating the host is not in expected state.

@Fei-Guo Iptables rules in makeupIptablesRules, Each rule has its own role, and there is no correlation between the rules. so we can skip the error and continue the later iptables rule setting.

@Fei-Guo
Copy link
Member

Fei-Guo commented Nov 3, 2021

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Nov 3, 2021
@openyurt-bot openyurt-bot merged commit c960daf into openyurtio:master Nov 3, 2021
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants