Yurtctl revert adds the function of deleting yurt app manager #555
Conversation
|
@yanyhui: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/yurtctl/cmd/revert/revert.go
Outdated
| @@ -20,6 +20,8 @@ import ( | |||
| "context" | |||
| "fmt" | |||
|
|
|||
| "k8s.io/client-go/dynamic" | |||
pkg/yurtctl/cmd/revert/revert.go
Outdated
| func removeYurtAppManager(client *kubernetes.Clientset, yurtAppManagerClientSet dynamic.Interface) error { | ||
| // 1. remove the Deployment | ||
| if err := client.AppsV1(). | ||
| Deployments(constants.YurttunnelNamespace). |
There was a problem hiding this comment.
How about rename constants.YurttunnelNamespace bacause constants.YurttunnelNamespace is used in func removeYurtAppManager and func removeYurtTunnelServer.
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, yanyhui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rtio#555) yurtctl revert add func to delete yurtappmanager
What type of PR is this?
/kind feature
What this PR does / why we need it:
Automatically delete the yurtappmanager function.
Which issue(s) this PR fixes:
Fixes #392
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note