Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Conntrack no matching connections process #741

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

huiwq1990
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature

Conntrack return error when no matching connections are found, openyurt should treat it as normal case.

/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Same case in: kubernetes

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature

Conntrack return error when no matching connections are found, openyurt should treat it as normal case.

/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Same case in: kubernetes

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Feb 16, 2022
@openyurt-bot
Copy link
Collaborator

Welcome @huiwq1990! It looks like this is your first PR to openyurtio/openyurt 🎉

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Feb 16, 2022
@rambohe-ch
Copy link
Member

@huiwq1990 Very appreciate for making pull request. please fix the golangci lint error by following the github actions.

@huiwq1990
Copy link
Member Author

@huiwq1990 Very appreciate for making pull request. please fix the golangci lint error by following the github actions.

Alray fix it.

Signed-off-by: huiwq1990 <huiwq1990@163.com>
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 0ceb1c8 into openyurtio:master Mar 3, 2022
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Signed-off-by: huiwq1990 <huiwq1990@163.com>
@huiwq1990 huiwq1990 deleted the feat-conntrack branch April 8, 2022 09:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants