support config k8s resource server #751
Conversation
|
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@huiwq1990 Thanks for your contribution. And could you please add some details about why we need this option? |
In private delivery scenes, network maybe not allow access public domain , it's better allow custom define resource address. |
@huiwq1990 Thanks for your feedback. it looks reasonable to add this parameter, @Congrool how about your advices? |
pkg/yurtctl/cmd/join/join.go
Outdated
| @@ -159,21 +161,26 @@ func addJoinConfigFlags(flagSet *flag.FlagSet, joinOptions *joinOptions) { | |||
| &joinOptions.nodeLabels, options.NodeLabels, joinOptions.nodeLabels, | |||
| "Sets the labels for joining node", | |||
| ) | |||
| flagSet.StringVar( | |||
| &joinOptions.kubernetesResourceServer, options.KubernetesResourceServer, joinOptions.kubernetesResourceServer, | |||
| "Sets the address for download k8s node resources", | |||
There was a problem hiding this comment.
Maybe we should modify it as Sets the address for downloading k8s node resources
|
@huiwq1990 Thanks for fixing comments, please merge two commits into one commit. |
huiwq1990
force-pushed
the
feat-k8sresource
branch
from
fe3b0ce to
7230a1e
Compare
Already done. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huiwq1990, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note