Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade the golint ci step #792

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

huiwq1990
Copy link
Member

@huiwq1990 huiwq1990 commented Apr 6, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Process golint error.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Congrool
Copy link
Member

Congrool commented Apr 6, 2022

@huiwq1990 hi, I'm also watching this problem.
From my opinion, it happens because the golangci-lint action uses golang 1.18, which still has some problems left. We can set it over v3 to solve it.

v3.0.0+ requires explicit setup-go installation step prior to using this action: uses: actions/setup-go@v2.
The skip-go-installation option has been removed.

@@ -42,10 +42,9 @@ jobs:
with:
go-version: ${{ env.GO_VERSION }}
- name: Lint golang code
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v2.5.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please set it as

golangci/golangci-lint-action@v3

and find if it works?

@Congrool
Copy link
Member

Congrool commented Apr 6, 2022

It seems that currently the error is not caused by golang 1.18 any more. There're some files cannot pass the lint check. Maybe we can revise these files according to the error output.

@Congrool
Copy link
Member

Congrool commented Apr 6, 2022

Good Job.
/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 6, 2022
@huiwq1990 huiwq1990 changed the title support golang ci upgrade the golint ci step Apr 6, 2022
@huiwq1990
Copy link
Member Author

It seems that currently the error is not caused by golang 1.18 any more. There're some files cannot pass the lint check. Maybe we can revise these files according to the error output.

Yes, all step are success.

@openyurt-bot openyurt-bot added the approved approved label Apr 7, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@rambohe-ch
Copy link
Member

/assign @rambohe-ch

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huiwq1990, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadisi
Copy link
Member

kadisi commented Apr 7, 2022

/lgtm

@huiwq1990 huiwq1990 deleted the feat-golint branch April 7, 2022 15:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants