-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
upgrade the golint ci step #792
Conversation
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@huiwq1990 hi, I'm also watching this problem.
|
.github/workflows/ci.yaml
Outdated
@@ -42,10 +42,9 @@ jobs: | |||
with: | |||
go-version: ${{ env.GO_VERSION }} | |||
- name: Lint golang code | |||
uses: golangci/golangci-lint-action@v2 | |||
uses: golangci/golangci-lint-action@v2.5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please set it as
golangci/golangci-lint-action@v3
and find if it works?
It seems that currently the error is not caused by golang 1.18 any more. There're some files cannot pass the lint check. Maybe we can revise these files according to the error output. |
Good Job. |
Yes, all step are success. |
/lgtm |
/assign @rambohe-ch |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huiwq1990, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Process golint error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note