-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
upgrade kubeadm to 1.22 #864
Conversation
@huiwq1990: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For tracing the origin of these introduced code in the future, could you please give some information in this PR about where these code copied from, including the commit/tag of kubernetes and the paths of original file? @huiwq1990 |
|
||
// KubernetesResourceServer flag sets the address for download k8s node resources. | ||
KubernetesResourceServer = "kubernetes-resource-server" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd better make pkg/util/kubernetes
only contain code what introduced from kubernetes. For code that will be used by yurtadm, we can move them to pkg/yurtadm/constants
.
@Congrool The code I fork is release-1.22, and the commit is kubernetes/kubernetes@67a57c4 |
@huiwq1990 How about using code of v1.22.3, because other introduced packages are from this version. See go.mod |
Yes, it's better use that version, i will fix it later. |
b1357be
to
4ce4f82
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huiwq1990, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Prepare for yurtadm token subcommand.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note