Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Proposal] add yurtadm proposal #902

Closed
wants to merge 1 commit into from

Conversation

windydayc
Copy link
Member

@windydayc windydayc commented Jul 5, 2022

What type of PR is this?

/kind feature
/kind design

What this PR does / why we need it:

add yurtadm proposal.

Special notes for your reviewer:

/assign @rambohe-ch
/assign @Peeknut

@openyurt-bot
Copy link
Collaborator

@windydayc: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot requested review from kadisi and rambohe-ch July 5, 2022 03:33
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: windydayc
To complete the pull request process, please assign fei-guo
You can assign the PR to them by writing /assign @fei-guo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@475c156). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #902   +/-   ##
=========================================
  Coverage          ?   43.66%           
=========================================
  Files             ?       83           
  Lines             ?    11260           
  Branches          ?        0           
=========================================
  Hits              ?     4917           
  Misses            ?     5908           
  Partials          ?      435           
Flag Coverage Δ
unittests 43.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

@windydayc because sealer can not support render openyurt version info into kubefile, so it's not convenient to build OpenYurt cluster image in a github action pipeline.

and we need to follow the sealer progress, then we can add a new pipeline when sealer supports it. so i will close this proposal now.

@rambohe-ch rambohe-ch closed this Aug 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/design kind/design kind/feature kind/feature size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants