Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docker build and helm deploy support #29

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

huiwq1990
Copy link
Member

Support docker build and helm deploy.

@luc99hen
Copy link
Member

luc99hen commented Mar 1, 2022

Thank you for your contribution!
This PR is very helpful, containerization is exactly what yurt-dashboard need right now.

@luc99hen luc99hen requested a review from qclc March 1, 2022 11:10
@huiwq1990 huiwq1990 force-pushed the feat-docker branch 2 times, most recently from 9734ccb to fb1c3f8 Compare March 2, 2022 07:04
@rambohe-ch
Copy link
Member

/assign @luc99hen

Copy link
Member

@qclc qclc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please merge the two commits into one. @huiwq1990

@huiwq1990
Copy link
Member Author

Thanks for your contribution. Please merge the two commits into one. @huiwq1990

I already mege them.

Makefile Outdated Show resolved Hide resolved
@qclc
Copy link
Member

qclc commented Mar 11, 2022

At the same time, how about briefly describe the latest deployment method to guide users how to use ? @huiwq1990
(You can directly add the latest helm deployment method to the ReadMe.md file.)

@luc99hen
Copy link
Member

@huiwq1990 @qclc , thanks for your efforts.
If there are no other suggestions, I am going to merge this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants