Skip to content

Commit

Permalink
Merge pull request #133 from openzipkin/revert-kafka-0.9
Browse files Browse the repository at this point in the history
Reverts Kafka client to 0.8.x to avoid broker compatibility issues
  • Loading branch information
adriancole committed Feb 13, 2016
2 parents e3bdb21 + ee79107 commit fa962ad
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions brave-spancollector-kafka/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<kafka.version>0.9.0.0</kafka.version>
<!-- This is pinned to Kafka 0.8.x client as 0.9.x brokers work with them, but not visa-versa
http://docs.confluent.io/2.0.0/upgrade.html -->
<kafka.version>0.8.2.2</kafka.version>
</properties>

<dependencies>
Expand All @@ -46,7 +48,8 @@
<dependency>
<groupId>com.github.charithe</groupId>
<artifactId>kafka-junit</artifactId>
<version>1.8</version>
<!-- pinned to 0.8.2.2 -->
<version>1.7</version>
<scope>test</scope>
</dependency>
<!-- org.apache.thrift.ProcessFunction v0.9 uses SLF4J at runtime -->
Expand Down

0 comments on commit fa962ad

Please # to comment.