Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

migrate to zipkin-java'like deployment #161

Closed
codefromthecrypt opened this issue Apr 25, 2016 · 11 comments
Closed

migrate to zipkin-java'like deployment #161

codefromthecrypt opened this issue Apr 25, 2016 · 11 comments

Comments

@codefromthecrypt
Copy link
Member

Most impactful would be changing the group id from "com.github.kristofa" to "io.zipkin.brave". If we do, then we can use bintray instead of sonatype. This has the advantage of group access controls and nice things like auto-signing of jars. Most importantly, we can use the same process to release zipkin-java and brave.
@codefromthecrypt
Copy link
Member Author

cc @abesto @eirslett @kristofa

@kristofa
Copy link
Member

@adriancole I'm all for it. It is good to have consistency and it prevents I'm the only one who can make releases for brave. It the release process described somewhere?

@codefromthecrypt
Copy link
Member Author

codefromthecrypt commented May 16, 2016 •
edited
Loading

I've extracted the maven sync plugin which @abesto and I worked on. Once this is in, we can switch brave to use openzipkin process openzipkin-attic/centralsync-maven-plugin#1

@codefromthecrypt
Copy link
Member Author

added a bintray package and requested it added to jcenter https://bintray.com/openzipkin/maven/brave/view

@codefromthecrypt
Copy link
Member Author

so.. for releasing brave from OZ. We've the parts to do this now.
easiest way would be to just change the maven group id as opposed to trying to deploy to 2 different group ids
ex change it from com.github.kristofa to io.zipkin.brave
then brave 3.7.1 or whatever would require folks to update their maven config

codefromthecrypt pushed a commit that referenced this issue May 19, 2016
Uses OpenZipkin deploy process and migrates to io.zipkin.brave group id
3d75ef3 
This re-uses the deployment flow from zipkin-java which has the
following features:

* Makes Brave releaseable by anyone with access to the Bintray org
* Snapshot publishing to http://oss.jfrog.org/artifactory/oss-snapshot-local
* Fully automated release to maven central via release-N.N.N tag
  * Releases also published to https://jcenter.bintray.com

Notably, this migrates the maven group id to `io.zipkin.brave`. This
needs to be communicated on release!

Fixes #161
@codefromthecrypt codefromthecrypt mentioned this issue May 19, 2016
Merged
@codefromthecrypt
Copy link
Member Author

here's the change to turn this on! #178

@codefromthecrypt
Copy link
Member Author

http://oss.jfrog.org/artifactory/oss-snapshot-local/io/zipkin/brave/ has snapshots now

@codefromthecrypt
Copy link
Member Author

pushed tag release-3.8.0 and seeing if it works!

https://travis-ci.org/openzipkin/brave/builds/131542806

@codefromthecrypt
Copy link
Member Author

done! https://travis-ci.org/openzipkin/brave/builds/131561655

@kristofa
Copy link
Member

Nice! 👍

@abesto
Copy link
Member

abesto commented May 22, 2016

Awesome sauce. 🎆 🍰

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abesto @codefromthecrypt @kristofa