Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates for Kafka clients/streams 3.0 #1322

Merged
merged 10 commits into from
Apr 4, 2022
Merged

Conversation

jeqo
Copy link
Member

@jeqo jeqo commented Jan 3, 2022

Fixes #1316

Changes:

  • Upgrade kafka-junit
  • Upgrade kafka clients/streams dependency
  • Forward close(long, TimeUnit) to close() for backward compatibililty

@jeqo jeqo marked this pull request as ready for review January 25, 2022 22:31
@jeqo jeqo requested a review from jcchavezs January 25, 2022 22:34
@jcchavezs
Copy link
Contributor

Changes look good. Does this guarantee the instrumentation still work with 2.6.0 or it will only work with 3.0.0 from now on? Can we support both? Shall we support both? If yes, can we in CI change kafka.version value to 2.6.0 and re-run these tests (so we make sure this works with both?)

@jeqo
Copy link
Member Author

jeqo commented Feb 10, 2022

Yes, this implement new methods without forcing clients to use them. So if client is in a previous version it should be ok with the existing instrumentations. We have integration tests with previous versions to validate this.
The kafka-junit dependency is also supporting 3.0 at the moment, so I think it should be ok to merge this.

cc @TYsewyn and @codependent to get your feedback as well.

@jcchavezs jcchavezs merged commit 9844b3c into openzipkin:master Apr 4, 2022
@jcchavezs
Copy link
Contributor

@jeqo do you mind cutting a release?

@jeqo jeqo deleted the kafka-3.0 branch April 4, 2022 09:48
@jeqo
Copy link
Member Author

jeqo commented Apr 4, 2022

5.13.8 released https://github.com/openzipkin/brave/actions/runs/2089233009

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka Streams instrumentation not compatible with kafka-streams 3.0.0
2 participants