-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Updates for Kafka clients/streams 3.0 #1322
Conversation
Changes look good. Does this guarantee the instrumentation still work with 2.6.0 or it will only work with 3.0.0 from now on? Can we support both? Shall we support both? If yes, can we in CI change |
Yes, this implement new methods without forcing clients to use them. So if client is in a previous version it should be ok with the existing instrumentations. We have integration tests with previous versions to validate this. cc @TYsewyn and @codependent to get your feedback as well. |
@jeqo do you mind cutting a release? |
Fixes #1316
Changes:
kafka-junit
close(long, TimeUnit)
toclose()
for backward compatibililty