Support Apache HttpAsyncClient "client received" #308
Conversation
Before, BraveHttpResponseInterceptor would call ClientResponseInterceptor and it would call setClientReceived. But it would not submit the end annotation because the current client span was null. This is because the response interceptor is not called on the same thread as the request interceptor. This can be solved by storing the client span as an attribute on the HttpContext instead.
|
yep this will do it. Thanks for the help! |
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpasyncclient</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
build seems to break on a snapshot repo #309
wonder if it is actually only this PR. can you try adding the version either here as <version>${httpcomponents.version}</version> or doing the same in the root pom under dependency management?
| @@ -188,6 +188,11 @@ | |||
| <version>${httpcomponents.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.httpcomponents</groupId> | |||
| <artifactId>httpasyncclient</artifactId> | |||
| <version>4.1.2</version> | |||
There was a problem hiding this comment.
actually can you switch to the same version pattern <version>${httpcomponents.version}</version> or is this unrelated to the other versions?
There was a problem hiding this comment.
ahh I see it is unrelated. this might be obvious to those who know this library, but not intuitive. mind adding an XML comment that this has a different versioning scheme vs the other files?
There was a problem hiding this comment.
Yeah, I was also confused because I tried to use ${httpcomponents.version} first. I'll raise a PR tomorrow :).
|
nuked the build cache which might let #309 pass |
|
thanks. point I mentioned wasn't important :P will be released in the next day or two, once #304 is done |
|
Awesome, thanks! |
Before, BraveHttpResponseInterceptor would call
ClientResponseInterceptor and it would call setClientReceived. But it
would not submit the end annotation because the current client span was
null. This is because the response interceptor is not called on the same
thread as the request interceptor.
This can be solved by storing the client span as an attribute on the
HttpContext instead.