Adds Brave 4 ServerTracer integration #334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An oversight in the initial Brave 4 TracerAdapter was how server spans
wire differently than local and client ones. Particularly, they carry
sampling status to prevent downstream trace commands from creating
children when unsampled.
fixes #332
Brave 3's ServerTracer works slightly differently than Brave 3's client
or local tracers. Internally, it uses a
ServerSpan
which keeps trackof the original sample status. To interop with ServerTracer, use the
following hooks:
Use
TracerAdapter.getServerSpan
to get one of..If you have a reference to a Brave 4 span, and know it represents a server
request, use
TracerAdapter.setServerSpan
to attach it to Brave 3's threadbinder.