Skip to content

improve: optional workflow result #2639

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

improve: optional workflow result #2639

merged 1 commit into from
Dec 17, 2024

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Dec 16, 2024

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Collaborator Author

csviri commented Dec 16, 2024

see discussion here: #2625 (comment)

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be an API breaking change, though…

@csviri
Copy link
Collaborator Author

csviri commented Dec 16, 2024

Since we have just beta release that should be fine.

@csviri csviri merged commit af31764 into main Dec 17, 2024
27 of 45 checks passed
@csviri csviri deleted the optional-worflow-result branch December 17, 2024 13:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultManagedWorkflowAndDependentResourceContext.workflowReconcileResult() throws Exception in case DRs have not been reconciled
2 participants