Skip to content

fix: use SSA matcher to filter events #2749

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

shawkins
Copy link
Collaborator

@shawkins shawkins commented Apr 1, 2025

closes: #2249

Seeing the recent #2742, I was wondering about revisiting #2249. One thought shown roughly here is that if we use the SSA matcher to compare the new / old. If it matches, then the change may not be meaningful as it didn't touch an owned field. Any normalization that kubernetes does wouldn't cause false positives here.

It's currently wired in dubiously - it probably would need to be done somehow via SSA enabled KubernetesDependentResources adding a filter to their informer event sources - which could make this independent of using the previous annotation.

When won't this work:

  • if you need to react to changes in things you don't own
  • if you miss handling an update that modifies your managed fields, after that point comparing the new / old like this doesn't help.

The only ways to workaround that I can think of would be to declare what non-owned state you care about and to track if we are behind on reconciling a resource - however these additional complexities may not be worth it.

closes: operator-framework#2249

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@shawkins shawkins requested review from csviri and metacosm April 1, 2025 16:00
@shawkins
Copy link
Collaborator Author

Given our other discussions, this is not worth persuing.

@shawkins shawkins closed this Apr 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependent Resource Event Filtration with Previous version as Annotation
1 participant