fix: event marking bug #2763
Merged
fix: event marking bug #2763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will try to add an unit test for this, but it might be the case that this did caused a real issue or just in extremely rare circumstances |
xstefank
approved these changes
Apr 11, 2025
metacosm
reviewed
Apr 11, 2025
| @@ -196,7 +196,7 @@ private void handleEventMarking(Event event, ResourceState state) { | |||
| // event as below. | |||
| markEventReceived(state); | |||
| } | |||
| } else if (!state.deleteEventPresent() || !state.processedMarkForDeletionPresent()) { | |||
| } else if (!state.deleteEventPresent() && !state.processedMarkForDeletionPresent()) { | |||
There was a problem hiding this comment.
Didn't we fix this already? I guess not but it rings a bell.
There was a problem hiding this comment.
I can't recall anything, but that does not mean we did not :)
metacosm
approved these changes
Apr 11, 2025
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com