Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Is there a plan to further refactor Helm Operator references of "update" to "upgrade"? #3346

Closed
mikeshng opened this issue Jul 6, 2020 · 2 comments
Closed

Is there a plan to further refactor Helm Operator references of "update" to "upgrade"? #3346

mikeshng opened this issue Jul 6, 2020 · 2 comments
Assignees
@camilamacedo86
Milestone
Backlog

Comments

@mikeshng
Copy link
Contributor

mikeshng commented Jul 6, 2020

Type of question

Based on #3269 and #3345 , the Helm Operator start using the verb Upgrade instead of Update.

Is there a plan to global refactor/rename from Update to Upgrade for all the relevant code under the operator-sdk/pkg/helm/ package tree?

Question

What did you do?

There are a lot of mentions of Update instead of Upgrade currently under operator-sdk/pkg/helm/ package.
For example, log entries log.Info("Updated release", "force", force), function name IsUpdateRequired etc etc.

What did you expect to see?
All the relevant Update references rename to Upgrade for example:

type UpdateOption func(*action.Upgrade) error

to

type UpgradeOption func(*action.Upgrade) error

What did you see instead? Under which circumstances?
I see Update instead of Upgrade being used.

Environment

  • operator-sdk version:

master branch

  • Kubernetes version information:

Not relevant

  • Kubernetes cluster kind:

Not relevant

FYI @camilamacedo86
@mikeshng mikeshng mentioned this issue Jul 10, 2020
Merged
1 task
@kensipe kensipe added this to the Backlog milestone Jul 13, 2020
@camilamacedo86
Copy link
Contributor

Add : #3404

@camilamacedo86 camilamacedo86 mentioned this issue Jul 13, 2020
Merged
camilamacedo86 added a commit that referenced this issue Jul 13, 2020
@camilamacedo86
helm/doc:replace the word update to upgrade in the info log (#3404)
67fe0df 
Description of the change:
Nit : helm/doc:replace the word update to upgrade in the info log

Related to : #3346
@camilamacedo86
Copy link
Contributor

Closing it since all was done and merged.
Thank you for the collab. 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@kensipe @camilamacedo86 @mikeshng